scheduler: hotspot: add pending influence #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luffbee
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #1982 +/- ##
==========================================
+ Coverage 77.35% 77.59% +0.23%
==========================================
Files 178 178
Lines 18149 18240 +91
==========================================
+ Hits 14040 14154 +114
+ Misses 3020 3009 -11
+ Partials 1089 1077 -12
Continue to review full report at Codecov.
|
rleungx
reviewed
Dec 3, 2019
lhy1024
reviewed
Dec 4, 2019
server/schedulers/hot_region.go
Outdated
| } | ||
| status := op.Status() | ||
| if !operator.IsEndStatus(status) { | ||
| return 1, false |
There was a problem hiding this comment.
The operator now is running, so we will estimate that all influence of this region is not observed by statistics.
| @@ -229,27 +259,35 @@ func (h *balanceHotRegionsScheduler) balanceHotReadRegions(cluster opt.Cluster) | |||
| const balanceHotRetryLimit = 10 | |||
|
|
|||
| func (h *balanceHotRegionsScheduler) balanceHotWriteRegions(cluster opt.Cluster) []*operator.Operator { | |||
| balancePeer := h.r.Int()%2 == 0 | |||
There was a problem hiding this comment.
Sometimes it will only try one balance strategy. I think that is not what we want.
lhy1024
reviewed
Dec 5, 2019
rleungx
reviewed
Dec 5, 2019
rleungx
reviewed
Dec 6, 2019
rleungx
approved these changes
Dec 6, 2019
Luffbee
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Schedulers may overscheduled because the influence of some operators is not observed.
What is changed and how it works?
This PR introduce "pending influence" which records operators and their influence, then amend the statistics according to operator status and influence.
Check List
Tests